diff mbox series

lttv: C99 compatibility fix

Message ID 87h6wyhd7l.fsf@oldenburg.str.redhat.com
State New
Headers show
Series lttv: C99 compatibility fix | expand

Commit Message

Florian Weimer Jan. 10, 2023, 10:54 a.m. UTC
While rebuilding Fedora with a C99 compiler, we noticed that we need
this patch to avoid a compilation error:


Related to:

  <https://fedoraproject.org/wiki/Changes/PortingToModernC>
  <https://fedoraproject.org/wiki/Toolchain/PortingToModernC>

Thanks,
Florian

Comments

Mathieu Desnoyers Jan. 10, 2023, 7:46 p.m. UTC | #1
Hi Florian,

I'll pull your patch into the lttv master branch, but please be aware
that the LTTV project has not seen activity since 2013, is currently
unmaintained, and that we do not plan on doing further releases of this
project. Our efforts were diverted elsewhere on the trace analysis
front, namely into Trace Compass and Babeltrace.

In order to clarify the situation, I will introduce a commit into
LTTV's master branch which will remove Yannick Brosseau from the
maintainer role in the README file, and add this section at the
beginning:

PROJECT STATUS
--------------------------------

The LTTV project is currently unmaintained. If you need up-to-date tools
to view/analyze LTTng traces, please consider the following alternatives:

- Trace Compass (https://www.eclipse.org/tracecompass)
- Babeltrace (https://babeltrace.org)


Thank you Yannick for stepping into the role of maintainer near the
end of this project lifetime.

Michael Jeanson noticed that the lttv Fedora package was orphaned.
He just adopted it and is currently investigating the Fedora
documentation to figure out how to request its removal from Fedora.

For those interested in historical artifacts, I created the lttv
svn repository back in 2003 when I was sitting at the Decelles building
at Ecole Polytechnique, working for Prof. Michel Dagenais:

commit bbdf43d6e0e3bd3f9ade420e81915408cbe4fbba
Author: compudj <compudj at 04897980-b3bd-0310-b5e0-8ef037075253>
Date:   Thu May 15 13:07:17 2003 +0000

     Initial repository layout
     
     git-svn-id: http://ltt.polymtl.ca/svn at 1 04897980-b3bd-0310-b5e0-8ef037075253

This was the beginning of a fun ride which turned out motivating the
creation of LTTng, the Linux kernel Tracepoints, the Common Trace Format,
Trace Compass, Babeltrace, liburcu, the membarrier(2), and the rseq(2)
system calls.

LTTV had a good 10 years of activity from 2003 to 2013, but it is now high
time to redirect users to Trace Compass and Babeltrace instead.

Thanks,

Mathieu
Florian Weimer Jan. 11, 2023, 11:01 a.m. UTC | #2
* Mathieu Desnoyers:

> Hi Florian,
>
> I'll pull your patch into the lttv master branch, but please be aware
> that the LTTV project has not seen activity since 2013, is currently
> unmaintained, and that we do not plan on doing further releases of this
> project. Our efforts were diverted elsewhere on the trace analysis
> front, namely into Trace Compass and Babeltrace.
>
> In order to clarify the situation, I will introduce a commit into
> LTTV's master branch which will remove Yannick Brosseau from the
> maintainer role in the README file, and add this section at the
> beginning:

Understood.  Fedora is building a lot of legacy software, and many of
the C99 fixes are in this area.

Thanks,
Florian
diff mbox series

Patch

diff --git a/lttv/lttv/state.c b/lttv/lttv/state.c
index 513c1bf3bb03ec7a..a1a31df2cbe6be30 100644
--- a/lttv/lttv/state.c
+++ b/lttv/lttv/state.c
@@ -271,7 +271,7 @@  gboolean rettrue(gpointer key, gpointer value, gpointer user_data)
 	return TRUE;
 }
 
-static guint check_expand(nb, id)
+static guint check_expand(int nb, int id)
 {
 	if(likely(nb > id))
 		return nb;