diff mbox series

[RFC,CTF,2/3] Clarify monotonicity requirement on timestamp begin

Message ID 20200423205226.496-3-mathieu.desnoyers@efficios.com
State Superseded, archived
Headers show
Series Common Trace Format Updates (upcoming 1.8.3) | expand

Commit Message

Mathieu Desnoyers April 23, 2020, 8:52 p.m. UTC
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
---
 common-trace-format-specification.md | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comments

Philippe Proulx April 28, 2020, 6:42 p.m. UTC | #1
----- Original Message -----
> From: "Mathieu Desnoyers" <mathieu.desnoyers at efficios.com>
> To: "gbastien+lttng" <gbastien+lttng at versatic.net>, "Matthew Khouzam" <matthew.khouzam at ericsson.com>,
> diamon-discuss at linuxfoundation.org, pproulx at efficios.com, "Jeremie Galarneau" <jgalar at efficios.com>
> Cc: "lttng-dev" <lttng-dev at lists.lttng.org>, "Mathieu Desnoyers" <mathieu.desnoyers at efficios.com>
> Sent: Thursday, 23 April, 2020 16:52:25
> Subject: [RFC PATCH CTF 2/3] Clarify monotonicity requirement on timestamp begin

> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
> common-trace-format-specification.md | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/common-trace-format-specification.md
> b/common-trace-format-specification.md
> index f5fea51..53b70f4 100644
> --- a/common-trace-format-specification.md
> +++ b/common-trace-format-specification.md
> @@ -836,10 +836,12 @@ TSDL metadata):
>     range between these timestamps should include all event timestamps
>     assigned to events contained within the packet. The timestamp at the
>     beginning of an event packet is guaranteed to be below or equal the
> -    timestamp at the end of that event packet. The timestamp at the end
> -    of an event packet is guaranteed to be below or equal the
> -    timestamps at the end of any following packet within the same stream.
> -    See [Clocks](#spec8) for more detail.
> +    timestamp at the end of that event packet. The timestamp at the
> +    beginning of an event packet is guaranteed to be above or equal the

"greater than or equal to"

> +    timestamps at the beginning of any prior packet within the same
> +    stream. The timestamp at the end of an event packet is guaranteed to
> +    be below or equal the timestamps at the end of any following packet

"less than or equal to"

Phil

> +    within the same stream. See [Clocks](#spec8) for more detail.
>   * **Events discarded count**. Snapshot of a per-stream
>     free-running counter, counting the number of events discarded that
>     were supposed to be written in the stream after the last event in
> --
> 2.11.0
Mathieu Desnoyers April 28, 2020, 6:54 p.m. UTC | #2
----- On Apr 28, 2020, at 2:42 PM, Philippe Proulx pproulx at efficios.com wrote:

> ----- Original Message -----
>> From: "Mathieu Desnoyers" <mathieu.desnoyers at efficios.com>
>> To: "gbastien+lttng" <gbastien+lttng at versatic.net>, "Matthew Khouzam"
>> <matthew.khouzam at ericsson.com>,
>> diamon-discuss at linuxfoundation.org, pproulx at efficios.com, "Jeremie Galarneau"
>> <jgalar at efficios.com>
>> Cc: "lttng-dev" <lttng-dev at lists.lttng.org>, "Mathieu Desnoyers"
>> <mathieu.desnoyers at efficios.com>
>> Sent: Thursday, 23 April, 2020 16:52:25
>> Subject: [RFC PATCH CTF 2/3] Clarify monotonicity requirement on timestamp begin
> 
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
>> ---
>> common-trace-format-specification.md | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>> 
>> diff --git a/common-trace-format-specification.md
>> b/common-trace-format-specification.md
>> index f5fea51..53b70f4 100644
>> --- a/common-trace-format-specification.md
>> +++ b/common-trace-format-specification.md
>> @@ -836,10 +836,12 @@ TSDL metadata):
>>     range between these timestamps should include all event timestamps
>>     assigned to events contained within the packet. The timestamp at the
>>     beginning of an event packet is guaranteed to be below or equal the
>> -    timestamp at the end of that event packet. The timestamp at the end
>> -    of an event packet is guaranteed to be below or equal the
>> -    timestamps at the end of any following packet within the same stream.
>> -    See [Clocks](#spec8) for more detail.
>> +    timestamp at the end of that event packet. The timestamp at the
>> +    beginning of an event packet is guaranteed to be above or equal the
> 
> "greater than or equal to"

done

> 
>> +    timestamps at the beginning of any prior packet within the same
>> +    stream. The timestamp at the end of an event packet is guaranteed to
>> +    be below or equal the timestamps at the end of any following packet
> 
> "less than or equal to"

done,

Thanks!

Mathieu

> 
> Phil
> 
>> +    within the same stream. See [Clocks](#spec8) for more detail.
>>   * **Events discarded count**. Snapshot of a per-stream
>>     free-running counter, counting the number of events discarded that
>>     were supposed to be written in the stream after the last event in
>> --
> > 2.11.0
diff mbox series

Patch

diff --git a/common-trace-format-specification.md b/common-trace-format-specification.md
index f5fea51..53b70f4 100644
--- a/common-trace-format-specification.md
+++ b/common-trace-format-specification.md
@@ -836,10 +836,12 @@  TSDL metadata):
     range between these timestamps should include all event timestamps
     assigned to events contained within the packet. The timestamp at the
     beginning of an event packet is guaranteed to be below or equal the
-    timestamp at the end of that event packet. The timestamp at the end
-    of an event packet is guaranteed to be below or equal the
-    timestamps at the end of any following packet within the same stream.
-    See [Clocks](#spec8) for more detail.
+    timestamp at the end of that event packet. The timestamp at the
+    beginning of an event packet is guaranteed to be above or equal the
+    timestamps at the beginning of any prior packet within the same
+    stream. The timestamp at the end of an event packet is guaranteed to
+    be below or equal the timestamps at the end of any following packet
+    within the same stream. See [Clocks](#spec8) for more detail.
   * **Events discarded count**. Snapshot of a per-stream
     free-running counter, counting the number of events discarded that
     were supposed to be written in the stream after the last event in