diff mbox series

[RFC,v2,11/13] Comments update

Message ID 20170918225206.17725-12-jonathan.rajotte-julien@efficios.com
State Superseded, archived
Delegated to: Jérémie Galarneau
Headers show
Series Sessiond teardown overhaul | expand

Commit Message

Jonathan Rajotte Sept. 18, 2017, 10:52 p.m. UTC
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien at efficios.com>
---
 src/bin/lttng-sessiond/main.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Jérémie Galarneau Dec. 14, 2017, 1:57 a.m. UTC | #1
LGTM.

Jérémie

On 18 September 2017 at 18:52, Jonathan Rajotte
<jonathan.rajotte-julien at efficios.com> wrote:
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien at efficios.com>
> ---
>  src/bin/lttng-sessiond/main.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
> index 216d0da6..a840e8de 100644
> --- a/src/bin/lttng-sessiond/main.c
> +++ b/src/bin/lttng-sessiond/main.c
> @@ -496,14 +496,18 @@ static int init_thread_apps_notify_teardown_trigger_pipe(void)
>  }
>
>  /*
> - * Stop all threads by closing the thread quit pipe.
> + * Stop first wave threads by closing the thread quit pipe.
> + *  - kernel thread
> + *  - client thread
> + *  - agent thread
> + *  - reg apps thread
>   */
>  static void stop_threads(void)
>  {
>         int ret;
>
> -       /* Stopping all threads */
> -       DBG("Terminating all threads");
> +       /* Stopping first wave threads */
> +       DBG("Terminating first wave threads");
>         ret = notify_thread_pipe(thread_quit_pipe[1]);
>         if (ret < 0) {
>                 ERR("write error on thread quit pipe");
> --
> 2.11.0
>
diff mbox series

Patch

diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
index 216d0da6..a840e8de 100644
--- a/src/bin/lttng-sessiond/main.c
+++ b/src/bin/lttng-sessiond/main.c
@@ -496,14 +496,18 @@  static int init_thread_apps_notify_teardown_trigger_pipe(void)
 }
 
 /*
- * Stop all threads by closing the thread quit pipe.
+ * Stop first wave threads by closing the thread quit pipe.
+ *  - kernel thread
+ *  - client thread
+ *  - agent thread
+ *  - reg apps thread
  */
 static void stop_threads(void)
 {
 	int ret;
 
-	/* Stopping all threads */
-	DBG("Terminating all threads");
+	/* Stopping first wave threads */
+	DBG("Terminating first wave threads");
 	ret = notify_thread_pipe(thread_quit_pipe[1]);
 	if (ret < 0) {
 		ERR("write error on thread quit pipe");