diff mbox

[lttng-modules] Fix: the clock plugin must be initiated before first use of the clock

Message ID 20160722135659.28595-1-wallinux@gmail.com
State Accepted, archived
Headers show

Commit Message

Anders Wallin July 22, 2016, 1:56 p.m. UTC
When building lttng inside the kernel the clock plugin must be initated
before the rest of the lttng code. Moved the module_init to
rootfs_initcall. The functionality will not change when built as a
module.

Signed-off-by: Anders Wallin <wallinux at gmail.com>
---
 tests/clock-plugin/lttng-clock-plugin-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mathieu Desnoyers July 22, 2016, 2:40 p.m. UTC | #1
Merged into lttng-modules master and stable-2.8, thanks!

Mathieu

----- On Jul 22, 2016, at 9:56 AM, Anders Wallin wallinux at gmail.com wrote:

> When building lttng inside the kernel the clock plugin must be initated
> before the rest of the lttng code. Moved the module_init to
> rootfs_initcall. The functionality will not change when built as a
> module.
> 
> Signed-off-by: Anders Wallin <wallinux at gmail.com>
> ---
> tests/clock-plugin/lttng-clock-plugin-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/clock-plugin/lttng-clock-plugin-test.c
> b/tests/clock-plugin/lttng-clock-plugin-test.c
> index f16ea64..bf81932 100644
> --- a/tests/clock-plugin/lttng-clock-plugin-test.c
> +++ b/tests/clock-plugin/lttng-clock-plugin-test.c
> @@ -67,7 +67,7 @@ int lttng_clock_plugin_init(void)
> {
> 	return lttng_clock_register_plugin(&ltc, THIS_MODULE);
> }
> -module_init(lttng_clock_plugin_init);
> +rootfs_initcall(lttng_clock_plugin_init);
> 
> static __exit
> void lttng_clock_plugin_exit(void)
> --
> 2.9.2
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
diff mbox

Patch

diff --git a/tests/clock-plugin/lttng-clock-plugin-test.c b/tests/clock-plugin/lttng-clock-plugin-test.c
index f16ea64..bf81932 100644
--- a/tests/clock-plugin/lttng-clock-plugin-test.c
+++ b/tests/clock-plugin/lttng-clock-plugin-test.c
@@ -67,7 +67,7 @@  int lttng_clock_plugin_init(void)
 {
 	return lttng_clock_register_plugin(&ltc, THIS_MODULE);
 }
-module_init(lttng_clock_plugin_init);
+rootfs_initcall(lttng_clock_plugin_init);
 
 static __exit
 void lttng_clock_plugin_exit(void)