diff mbox series

[lttng-ust,5/8] Fix: missing enum removal from the enum hashtable

Message ID 1517600891-23632-6-git-send-email-francis.deslauriers@efficios.com
State Superseded, archived
Headers show
Series Support provider duplicates and unloading | expand

Commit Message

Francis Deslauriers Feb. 2, 2018, 7:48 p.m. UTC
Signed-off-by: Francis Deslauriers <francis.deslauriers at efficios.com>
---
 liblttng-ust/lttng-events.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mathieu Desnoyers Feb. 7, 2018, 8:55 p.m. UTC | #1
----- On Feb 2, 2018, at 2:48 PM, Francis Deslauriers francis.deslauriers at efficios.com wrote:

Is it a fix or a preparation step for a new feature ?

Thanks,

Mathieu

> Signed-off-by: Francis Deslauriers <francis.deslauriers at efficios.com>
> ---
> liblttng-ust/lttng-events.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/liblttng-ust/lttng-events.c b/liblttng-ust/lttng-events.c
> index e8d4857..2b679b5 100644
> --- a/liblttng-ust/lttng-events.c
> +++ b/liblttng-ust/lttng-events.c
> @@ -990,6 +990,7 @@ static
> void _lttng_enum_destroy(struct lttng_enum *_enum)
> {
> 	cds_list_del(&_enum->node);
> +	cds_hlist_del(&_enum->hlist);
> 	free(_enum);
> }
> 
> --
> 2.7.4
Francis Deslauriers Feb. 8, 2018, 8:45 p.m. UTC | #2
2018-02-07 15:55 GMT-05:00 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>:
> ----- On Feb 2, 2018, at 2:48 PM, Francis Deslauriers francis.deslauriers at efficios.com wrote:
>
> Is it a fix or a preparation step for a new feature ?
Same thought process that with: cds_hlist_del(&event->hlist);

Thanks,
Francis
>
> Thanks,
>
> Mathieu
>
>> Signed-off-by: Francis Deslauriers <francis.deslauriers at efficios.com>
>> ---
>> liblttng-ust/lttng-events.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/liblttng-ust/lttng-events.c b/liblttng-ust/lttng-events.c
>> index e8d4857..2b679b5 100644
>> --- a/liblttng-ust/lttng-events.c
>> +++ b/liblttng-ust/lttng-events.c
>> @@ -990,6 +990,7 @@ static
>> void _lttng_enum_destroy(struct lttng_enum *_enum)
>> {
>>       cds_list_del(&_enum->node);
>> +     cds_hlist_del(&_enum->hlist);
>>       free(_enum);
>> }
>>
>> --
>> 2.7.4
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
Mathieu Desnoyers Feb. 8, 2018, 8:52 p.m. UTC | #3
----- On Feb 8, 2018, at 3:45 PM, Francis Deslauriers francis.deslauriers at efficios.com wrote:

> 2018-02-07 15:55 GMT-05:00 Mathieu Desnoyers <mathieu.desnoyers at efficios.com>:
>> ----- On Feb 2, 2018, at 2:48 PM, Francis Deslauriers
>> francis.deslauriers at efficios.com wrote:
>>
>> Is it a fix or a preparation step for a new feature ?
> Same thought process that with: cds_hlist_del(&event->hlist);

Not a fix then.

Thanks,

Mathieu

> 
> Thanks,
> Francis
>>
>> Thanks,
>>
>> Mathieu
>>
>>> Signed-off-by: Francis Deslauriers <francis.deslauriers at efficios.com>
>>> ---
>>> liblttng-ust/lttng-events.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/liblttng-ust/lttng-events.c b/liblttng-ust/lttng-events.c
>>> index e8d4857..2b679b5 100644
>>> --- a/liblttng-ust/lttng-events.c
>>> +++ b/liblttng-ust/lttng-events.c
>>> @@ -990,6 +990,7 @@ static
>>> void _lttng_enum_destroy(struct lttng_enum *_enum)
>>> {
>>>       cds_list_del(&_enum->node);
>>> +     cds_hlist_del(&_enum->hlist);
>>>       free(_enum);
>>> }
>>>
>>> --
>>> 2.7.4
>>
>> --
>> Mathieu Desnoyers
>> EfficiOS Inc.
>> http://www.efficios.com
> 
> 
> 
> --
> Francis Deslauriers
> Software developer
> EfficiOS inc.
diff mbox series

Patch

diff --git a/liblttng-ust/lttng-events.c b/liblttng-ust/lttng-events.c
index e8d4857..2b679b5 100644
--- a/liblttng-ust/lttng-events.c
+++ b/liblttng-ust/lttng-events.c
@@ -990,6 +990,7 @@  static
 void _lttng_enum_destroy(struct lttng_enum *_enum)
 {
 	cds_list_del(&_enum->node);
+	cds_hlist_del(&_enum->hlist);
 	free(_enum);
 }