diff mbox

[lttng-tools] Cleanup: Remove fun from code base

Message ID 1474828347-21108-1-git-send-email-mathieu.desnoyers@efficios.com
State Accepted, archived
Headers show

Commit Message

Mathieu Desnoyers Sept. 25, 2016, 6:32 p.m. UTC
It appears choosing the release names provides plenty of enjoyment to
LTTng developers, thus allowing us to remove those easter eggs.

Incidentally, it will allow me to demo the LTTng project without
carrying this <yellow>Welcome back Dr Tracing!</yellow> message each
time I issue a "lttng" command.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
---
 src/bin/lttng-sessiond/main.c | 6 ------
 src/bin/lttng/lttng.c         | 8 --------
 2 files changed, 14 deletions(-)

Comments

Jesper Derehag Sept. 27, 2016, 12:57 p.m. UTC | #1
ehhh... taking all the fun out of the job? =)

----------------------------------------
> From: mathieu.desnoyers at efficios.com
> To: jgalar at efficios.com
> Date: Sun, 25 Sep 2016 14:32:27 -0400
> CC: lttng-dev at lists.lttng.org
> Subject: [lttng-dev] [PATCH lttng-tools] Cleanup: Remove fun from code base
>
> It appears choosing the release names provides plenty of enjoyment to
> LTTng developers, thus allowing us to remove those easter eggs.
>
> Incidentally, it will allow me to demo the LTTng project without
> carrying this <yellow>Welcome back Dr Tracing!</yellow> message each
> time I issue a "lttng" command.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
> src/bin/lttng-sessiond/main.c | 6 ------
> src/bin/lttng/lttng.c | 8 --------
> 2 files changed, 14 deletions(-)
>
> diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
> index b067461..5e19f37 100644
> --- a/src/bin/lttng-sessiond/main.c
> +++ b/src/bin/lttng-sessiond/main.c
> @@ -760,12 +760,6 @@ static void sessiond_cleanup_options(void)
> free(kmod_extra_probes_list);
>
> run_as_destroy_worker();
> -
> - /* <fun> */
> - DBG("%c[%d;%dm*** assert failed :-) *** ==> %c[%dm%c[%d;%dm"
> - "Matthew, BEET driven development works!%c[%dm",
> - 27, 1, 31, 27, 0, 27, 1, 33, 27, 0);
> - /* </fun> */
> }
>
> /*
> diff --git a/src/bin/lttng/lttng.c b/src/bin/lttng/lttng.c
> index 34816be..9317e83 100644
> --- a/src/bin/lttng/lttng.c
> +++ b/src/bin/lttng/lttng.c
> @@ -389,14 +389,6 @@ static int parse_args(int argc, char **argv)
> goto error;
> }
>
> - /* For Mathieu Desnoyers a.k.a. Dr. Tracing */
> - user = getenv("USER");
> - if (user != NULL && ((strncmp(progname, "drtrace", 7) == 0 ||
> - strncmp("compudj", user, 7) == 0))) {
> - MSG("%c[%d;%dmWelcome back Dr Tracing!%c[%dm\n", 27,1,33,27,0);
> - }
> - /* Thanks Mathieu */
> -
> /*
> * Handle leftovers which is a first level command with the trailing
> * options.
> --
> 2.1.4
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Jérémie Galarneau Sept. 27, 2016, 7:13 p.m. UTC | #2
Fun removed from master, thanks... ;)

Jérémie

On 25 September 2016 at 14:32, Mathieu Desnoyers
<mathieu.desnoyers at efficios.com> wrote:
> It appears choosing the release names provides plenty of enjoyment to
> LTTng developers, thus allowing us to remove those easter eggs.
>
> Incidentally, it will allow me to demo the LTTng project without
> carrying this <yellow>Welcome back Dr Tracing!</yellow> message each
> time I issue a "lttng" command.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
>  src/bin/lttng-sessiond/main.c | 6 ------
>  src/bin/lttng/lttng.c         | 8 --------
>  2 files changed, 14 deletions(-)
>
> diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
> index b067461..5e19f37 100644
> --- a/src/bin/lttng-sessiond/main.c
> +++ b/src/bin/lttng-sessiond/main.c
> @@ -760,12 +760,6 @@ static void sessiond_cleanup_options(void)
>         free(kmod_extra_probes_list);
>
>         run_as_destroy_worker();
> -
> -       /* <fun> */
> -       DBG("%c[%d;%dm*** assert failed :-) *** ==> %c[%dm%c[%d;%dm"
> -                       "Matthew, BEET driven development works!%c[%dm",
> -                       27, 1, 31, 27, 0, 27, 1, 33, 27, 0);
> -       /* </fun> */
>  }
>
>  /*
> diff --git a/src/bin/lttng/lttng.c b/src/bin/lttng/lttng.c
> index 34816be..9317e83 100644
> --- a/src/bin/lttng/lttng.c
> +++ b/src/bin/lttng/lttng.c
> @@ -389,14 +389,6 @@ static int parse_args(int argc, char **argv)
>                 goto error;
>         }
>
> -       /* For Mathieu Desnoyers a.k.a. Dr. Tracing */
> -       user = getenv("USER");
> -       if (user != NULL && ((strncmp(progname, "drtrace", 7) == 0 ||
> -                                       strncmp("compudj", user, 7) == 0))) {
> -               MSG("%c[%d;%dmWelcome back Dr Tracing!%c[%dm\n", 27,1,33,27,0);
> -       }
> -       /* Thanks Mathieu */
> -
>         /*
>          * Handle leftovers which is a first level command with the trailing
>          * options.
> --
> 2.1.4
>
Philippe Proulx Sept. 27, 2016, 7:24 p.m. UTC | #3
Finally this project is getting serious!
Philippe Proulx


On Tue, Sep 27, 2016 at 3:13 PM, Jérémie Galarneau
<jeremie.galarneau at efficios.com> wrote:
> Fun removed from master, thanks... ;)
>
> Jérémie
>
> On 25 September 2016 at 14:32, Mathieu Desnoyers
> <mathieu.desnoyers at efficios.com> wrote:
>> It appears choosing the release names provides plenty of enjoyment to
>> LTTng developers, thus allowing us to remove those easter eggs.
>>
>> Incidentally, it will allow me to demo the LTTng project without
>> carrying this <yellow>Welcome back Dr Tracing!</yellow> message each
>> time I issue a "lttng" command.
>>
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
>> ---
>>  src/bin/lttng-sessiond/main.c | 6 ------
>>  src/bin/lttng/lttng.c         | 8 --------
>>  2 files changed, 14 deletions(-)
>>
>> diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
>> index b067461..5e19f37 100644
>> --- a/src/bin/lttng-sessiond/main.c
>> +++ b/src/bin/lttng-sessiond/main.c
>> @@ -760,12 +760,6 @@ static void sessiond_cleanup_options(void)
>>         free(kmod_extra_probes_list);
>>
>>         run_as_destroy_worker();
>> -
>> -       /* <fun> */
>> -       DBG("%c[%d;%dm*** assert failed :-) *** ==> %c[%dm%c[%d;%dm"
>> -                       "Matthew, BEET driven development works!%c[%dm",
>> -                       27, 1, 31, 27, 0, 27, 1, 33, 27, 0);
>> -       /* </fun> */
>>  }
>>
>>  /*
>> diff --git a/src/bin/lttng/lttng.c b/src/bin/lttng/lttng.c
>> index 34816be..9317e83 100644
>> --- a/src/bin/lttng/lttng.c
>> +++ b/src/bin/lttng/lttng.c
>> @@ -389,14 +389,6 @@ static int parse_args(int argc, char **argv)
>>                 goto error;
>>         }
>>
>> -       /* For Mathieu Desnoyers a.k.a. Dr. Tracing */
>> -       user = getenv("USER");
>> -       if (user != NULL && ((strncmp(progname, "drtrace", 7) == 0 ||
>> -                                       strncmp("compudj", user, 7) == 0))) {
>> -               MSG("%c[%d;%dmWelcome back Dr Tracing!%c[%dm\n", 27,1,33,27,0);
>> -       }
>> -       /* Thanks Mathieu */
>> -
>>         /*
>>          * Handle leftovers which is a first level command with the trailing
>>          * options.
>> --
>> 2.1.4
>>
>
>
>
> --
> Jérémie Galarneau
> EfficiOS Inc.
> http://www.efficios.com
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
diff mbox

Patch

diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
index b067461..5e19f37 100644
--- a/src/bin/lttng-sessiond/main.c
+++ b/src/bin/lttng-sessiond/main.c
@@ -760,12 +760,6 @@  static void sessiond_cleanup_options(void)
 	free(kmod_extra_probes_list);
 
 	run_as_destroy_worker();
-
-	/* <fun> */
-	DBG("%c[%d;%dm*** assert failed :-) *** ==> %c[%dm%c[%d;%dm"
-			"Matthew, BEET driven development works!%c[%dm",
-			27, 1, 31, 27, 0, 27, 1, 33, 27, 0);
-	/* </fun> */
 }
 
 /*
diff --git a/src/bin/lttng/lttng.c b/src/bin/lttng/lttng.c
index 34816be..9317e83 100644
--- a/src/bin/lttng/lttng.c
+++ b/src/bin/lttng/lttng.c
@@ -389,14 +389,6 @@  static int parse_args(int argc, char **argv)
 		goto error;
 	}
 
-	/* For Mathieu Desnoyers a.k.a. Dr. Tracing */
-	user = getenv("USER");
-	if (user != NULL && ((strncmp(progname, "drtrace", 7) == 0 ||
-					strncmp("compudj", user, 7) == 0))) {
-		MSG("%c[%d;%dmWelcome back Dr Tracing!%c[%dm\n", 27,1,33,27,0);
-	}
-	/* Thanks Mathieu */
-
 	/*
 	 * Handle leftovers which is a first level command with the trailing
 	 * options.